JDevlieghere wrote:

> I think the PR is close to finish, except the "how to make sure hello.cpp 
> builds in Windows" question.

Does this test need to build on Windows? That test should only run on Darwin, 
so if it's properly skipped, we shouldn't even try to build the inferior. The 
Windows-conditional parts will be dead code.

Besides that this LGTM



https://github.com/llvm/llvm-project/pull/139174
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to