llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) <details> <summary>Changes</summary> I forgot to use the non-synthetic value to check for the `_Ptr` member. Fixes the test failure from #<!-- -->147575. --- Full diff: https://github.com/llvm/llvm-project/pull/148176.diff 1 Files Affected: - (modified) lldb/source/Plugins/Language/CPlusPlus/MsvcStlSmartPointer.cpp (+2-1) ``````````diff diff --git a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlSmartPointer.cpp b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlSmartPointer.cpp index 4a51879863f17..b5a85ab5deb8b 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlSmartPointer.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlSmartPointer.cpp @@ -15,7 +15,8 @@ using namespace lldb; bool lldb_private::formatters::IsMsvcStlSmartPointer(ValueObject &valobj) { - return valobj.GetChildMemberWithName("_Ptr") != nullptr; + ValueObjectSP valobj_sp = valobj.GetNonSyntheticValue(); + return valobj_sp->GetChildMemberWithName("_Ptr") != nullptr; } bool lldb_private::formatters::MsvcStlSmartPointerSummaryProvider( `````````` </details> https://github.com/llvm/llvm-project/pull/148176 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
