================ @@ -1130,9 +1122,9 @@ MinidumpFileBuilder::AddMemoryList_64(std::vector<CoreFileMemoryRange> &ranges, // Capture the starting offset for all the descriptors so we can clean them up // if needed. offset_t starting_offset = - GetCurrentDataEndOffset() + sizeof(llvm::support::ulittle64_t); + GetCurrentDataEndOffset() + sizeof(llvm::minidump::Memory64ListHeader); ---------------- dmpots wrote:
So this is the actual bug fix right? I wonder if it would be better to put this as a separate commit. It maybe is hard to test without the other changes, but it would at least clearly separate the bug fix from the change in behavior. Makes it safer in case we need to revert the change to 64b by default that we would not also revert the bug fix. https://github.com/llvm/llvm-project/pull/146777 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
