krytarowski added a comment. In https://reviews.llvm.org/D29288#660703, @mehdi_amini wrote:
> In https://reviews.llvm.org/D29288#660677, @krytarowski wrote: > > > In https://reviews.llvm.org/D29288#660636, @clayborg wrote: > > > > > Be very careful when using this, you can't change member variables that > > > used to be std::once to be statics. We also don't need the llvm namespace > > > to be included with "using namespace llvm;" in many of the files. > > > > > > `using namespace llvm;` is currently required in order to get this > > functional: > > > What about just updating the macro in LLVM to make it not needed? > > #define LLVM_DEFINE_ONCE_FLAG(flag) static llvm::once_flag flag = > Uninitialized > Right, this looks cleaner. I will propose this patch as a separated review. Repository: rL LLVM https://reviews.llvm.org/D29288 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
