labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

This is also copying a lot of code only to make tiny changes to it. Please put 
the Linux process launcher into the posix folder (I suggest naming it 
ProcessLauncherPosixFork). Ifdef out the linux-specific parts (ASLR, 
personality) and you're done. :)

For bonus points, you can put the ASLR code into a separate function, and then 
ifdef-out only that - should make main code flow better.


Repository:
  rL LLVM

https://reviews.llvm.org/D29347



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to