dsandersllvm wrote: While looking into that, I found a couple mistakes that made me question how it managed to work and I found that that bit is not actually used. ConcreteRegisterLocation uses eRegisterIsRegisterPlusOffset for all reg+offset's including reg=CFA, but AbstractRegisterLocation has a specific isCFAPlusOffset for the reg=CFA case so I didn't need to add isOtherRegisterPlusOffset
I just pushed an update that removes that unnecessary code and fixes the clang-format issue raised by the bot https://github.com/llvm/llvm-project/pull/150732 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits