================
@@ -134,7 +134,9 @@ bool TypeQuery::ContextMatches(
     if (ctx == ctx_end)
       return false; // Pattern too long.
 
-    if (ctx->kind == CompilerContextKind::Namespace && ctx->name.IsEmpty()) {
+    if ((ctx->kind & CompilerContextKind::Namespace) ==
----------------
labath wrote:

If you can identify tag types, then I think it's safe to assume that the rest 
are namespaces (particularly if that's the same approach we use when 
constructing the clang AST for these types). 

Your test looks reasonable to me. I'd consider using lldb-test (like 
lldb/test/Shell/SymbolFile/DWARF/x86/find-basic-type.cpp does) instead, mainly 
because it lets you distinguish multiple instances of `S` better, but I 
wouldn't say that's required.

https://github.com/llvm/llvm-project/pull/149876
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to