[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

[Augusto Noronha via lldb-commits]

================
@@ -182,11 +184,13 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
                                      expr);
       }
 
-      bool failed = errorToBool(dump_val_object(*valobj_sp));
-      if (!failed)
+      Error err = dump_val_object(*valobj_sp);
+      if (!err)
         return;
 
       // Dump failed, continue on to expression evaluation.
+      LLDB_LOG_ERROR(GetLog(LLDBLog::Expressions), std::move(err),
----------------
augusto2112 wrote:

I'm confused about the order of the arguments to this macro. The error comes 
first, then the format string, then the other parameter?

https://github.com/llvm/llvm-project/pull/151374
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits