================
@@ -125,19 +126,43 @@ ExecutionContext::ExecutionContext(const 
ExecutionContextRef *exe_ctx_ref_ptr,
   }
 }
 
-ExecutionContext::ExecutionContext(const ExecutionContextRef *exe_ctx_ref_ptr,
-                                   std::unique_lock<std::recursive_mutex> 
&lock)
+ExecutionContext::ExecutionContext(
----------------
felipepiovezan wrote:

@jimingham If I understand Jonas's point correctly, the suggestions is that, 
while the constructor MAY put the ExecutionContext in 
valid-but-intermediate-state, none of the users of that constructor are using 
that intermediate state. So we might as well get rid of it, create an 
"all-or-nothing" constructor/method, and if someone wants the intermediate 
state in the future, they can create a new constructor.

What do you think?

https://github.com/llvm/llvm-project/pull/152020
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to