================
@@ -640,6 +640,13 @@ void IRMemoryMap::WritePointerToMemory(lldb::addr_t 
process_address,
                                        lldb::addr_t address, Status &error) {
   error.Clear();
 
+  /// Only ask the Process to fix the address if this address belongs to the
+  /// process (host allocations are stored in m_data).
----------------
felipepiovezan wrote:

> will lead most people to wonder why we fix pointers written into the process

I'm not sure I agree with this. Yes, the host might be running the process, but 
if anything I think most people would ask "Why would a class called `Process` 
fix an address that doesn't belong to _the process_?".

https://github.com/llvm/llvm-project/pull/153585
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to