jimingham wrote: You said above that this code wouldn't get used if the description expression crashed. Why is that? Even if we can't get a diagnostic error from the crash process, it would be nice to use this same codepath to do:
``` (lldb) po bogus_description Warning: po description expression crashed, printing value (BogusDescription *) 0x12345 ``` or something? If it did that we could also write a test here, which would make this feel better... The code looks okay except it would be nice to change all the places where we're saying "DisableObjectiveC" to say "DisableObjectDescription" or something (and `m_use_objc` -> `m_use_object_desc`). You didn't start that but you're adding another instance, and it would be good not to extend the mistake... We call it the right thing in all the public facing API's, the confusing name is just internal. It will look really silly when this goes to the swift fork and we're using `m_use_objc` or DisableObjectiveC() to say whether or not we want the description of a swift object (or any other language that has some kind of object description machinery.) https://github.com/llvm/llvm-project/pull/152417 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
