zturner added a comment.
Where is the logging callback used? It seems rather odd that we would need to
notify someone every time a log message was generated.
================
Comment at: source/Core/StreamCallback.cpp:22
StreamCallback::StreamCallback(lldb::LogOutputCallback callback, void *baton)
- : Stream(0, 4, eByteOrderBig), m_callback(callback), m_baton(baton),
- m_accumulated_data(), m_collection_mutex() {}
----------------
I find it rather odd that this was hardcoding big endian. Was the endianness
here important for some reason?
https://reviews.llvm.org/D29615
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
