================ @@ -981,6 +981,23 @@ struct WriteMemoryResponseBody { }; llvm::json::Value toJSON(const WriteMemoryResponseBody &); +struct DAPGetModuleSymbolsArguments { + /// The module UUID for which to retrieve symbols. + std::optional<std::string> moduleId; ---------------- ashgti wrote:
I think a `std::string` that is empty is indistinguishable from an `std::optional<std::string>`, could these just be `std::string` types and in the `fromJSON` we use `mapOptional`? Then in the implementation we can check `.empty()`. https://github.com/llvm/llvm-project/pull/153836 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits