clayborg added a comment.

If it isn't making too much extra code I am fine with it being separate if you 
believe this is the right way forward. Give it some thought and if you still 
believe they should be separate, I won't object. It might be nice to send the 
HardwareBreakpoint structure down to the functions that are going to 
enable/disable the HW breakpoints instead of individual arguments as you may 
end up adding members to the HardwareBreakpoint in the future and this will 
keep you from having to update all of the signatures.


https://reviews.llvm.org/D29669



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to