ashgti wrote: > Let's split out the changes to the protocol, we can land and test those > independently and that would simplify this patch a lot. I also think all the > socket code is (not yet) necessary.
Split the protocol changes into #155460 and I'll also add another to move the MCPTransport into its own file instead of being in the Server.h file. > > You say the purpose of the binder is to bind handlers to requests and > notifications. Currently, that's part of the server, and this is splitting > that off. > > * Can you explain why that's necessary going forward? The Binder is for creating bindings between functions and the transport. This lets you create a server or a client by choosing the directions of the bindings. I was using this to create bindings for an lldb-mcp server that would acts a coordinator between lldb instances and mcp clients. However, I think I'll take another look at this approach and see if we can do this without a full server binary. I'll mark this as a draft until I have a chance to look at this first. https://github.com/llvm/llvm-project/pull/155315 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
