medismailben wrote: > @medismailben lldb-dap is usable from Zed with my most recent commit now! Do > you have time this week to pair on getting this mergable? I'm pretty sure > using new variable ids is going to break some tests and idk if there's > formatters or anything else I have to fix to get CICD passing
Awesome! I've kicked a llvm PR testing for your patch and it looks like the formatter job passed however there is some DAP test failures: ``` ******************** Unresolved Tests (1): lldb-api :: tools/lldb-dap/databreakpoint/TestDAP_setDataBreakpoints.py ******************** Failed Tests (3): lldb-api :: tools/lldb-dap/memory/TestDAP_memory.py lldb-api :: tools/lldb-dap/variables/TestDAP_variables.py lldb-unit :: DAP/./DAPTests/VariablesTest/GetTopLevelScope_ReturnsCorrectScope Testing Time: 93.86s ``` You should be able to look at the logs here: https://github.com/llvm/llvm-project/actions/runs/17280350831/job/49047894529?pr=124232 You can run the `ninja check-lldb-api-tools-lldb-dap` to run the DAP tests locally. It would be nice to add your own test to make sure this doesn't regress in the future. Also, make sure to turn your draft into a PR when it's ready for review. https://github.com/llvm/llvm-project/pull/124232 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
