DavidSpickett wrote:

> Yes, in these tests, execution during the step is inside the inline assembly 
> block, so I hope the mnemonics will be stable.

Understood.

> This patch rewrites the test to avoid this disadvantage. The test now checks 
> the opcode of the instruction after the step instead of the step distance.

So please extend the sentence "This patch rewrites the test to avoid this 
disadvantage." to state that you do this by avoiding checking for any compiler 
generated locations.

https://github.com/llvm/llvm-project/pull/156506
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to