JDevlieghere wrote: > Great! May be we should do this for: > > * `Status::Status(std::string err_str)` > * `static Status FromErrorString(const char *str)` > * `static Status FromErrorStringWithFormat(const char *format, ...)` > * `template <typename... Args> static Status FromErrorStringWithFormatv(const > char *format, Args &&...args)`
Yeah, those are all good functions to grep for. > Also, it would be great if we had a clang-tidy checker as part of the CI > testing to catching this inconsistencies earlier 👀 It would be nice to automate. Currently, we don't run any clang-tidy checks in CI and I think it would be most valuable if that were part of the pre-commit checks. The clang-tidy checks are a lot more expensive than the formatters though, so I don't know if that's even on the table. Might be an interesting topic for the infa workgroup. https://github.com/llvm/llvm-project/pull/156774 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
