https://github.com/lexi-nadia created
https://github.com/llvm/llvm-project/pull/157178
None
>From 088a1dd896e7bbb27e4be3a59fd241928e0fccfd Mon Sep 17 00:00:00 2001
From: lexinadia <lexina...@google.com>
Date: Fri, 5 Sep 2025 17:40:29 +0000
Subject: [PATCH 1/4] Default-initialize all fields of
lldb_dap::protocol::Symbol.
---
.../Handler/ModuleSymbolsRequestHandler.cpp | 2 +-
lldb/tools/lldb-dap/Protocol/DAPTypes.h | 16 ++++++++--------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/lldb/tools/lldb-dap/Handler/ModuleSymbolsRequestHandler.cpp
b/lldb/tools/lldb-dap/Handler/ModuleSymbolsRequestHandler.cpp
index 4c61138e5007e..4a9d256cfa975 100644
--- a/lldb/tools/lldb-dap/Handler/ModuleSymbolsRequestHandler.cpp
+++ b/lldb/tools/lldb-dap/Handler/ModuleSymbolsRequestHandler.cpp
@@ -60,7 +60,7 @@ ModuleSymbolsRequestHandler::Run(const ModuleSymbolsArguments
&args) const {
if (!symbol.IsValid())
continue;
- Symbol dap_symbol = {};
+ Symbol dap_symbol;
dap_symbol.id = symbol.GetID();
dap_symbol.type = symbol.GetType();
dap_symbol.isDebug = symbol.IsDebug();
diff --git a/lldb/tools/lldb-dap/Protocol/DAPTypes.h
b/lldb/tools/lldb-dap/Protocol/DAPTypes.h
index 7fccf1359a737..17a25c092b8dd 100644
--- a/lldb/tools/lldb-dap/Protocol/DAPTypes.h
+++ b/lldb/tools/lldb-dap/Protocol/DAPTypes.h
@@ -50,29 +50,29 @@ llvm::json::Value toJSON(const SourceLLDBData &);
struct Symbol {
/// The symbol id, usually the original symbol table index.
- uint32_t id;
+ uint32_t id = 0;
/// True if this symbol is debug information in a symbol.
- bool isDebug;
+ bool isDebug = false;
/// True if this symbol is not actually in the symbol table, but synthesized
/// from other info in the object file.
- bool isSynthetic;
+ bool isSynthetic = false;
/// True if this symbol is globally visible.
- bool isExternal;
+ bool isExternal = false;
/// The symbol type.
- lldb::SymbolType type;
+ lldb::SymbolType type = lldb::eSymbolTypeInvalid;
/// The symbol file address.
- lldb::addr_t fileAddress;
+ lldb::addr_t fileAddress = 0;
/// The symbol load address.
- std::optional<lldb::addr_t> loadAddress;
+ std::optional<lldb::addr_t> loadAddress = std::nullopt;
/// The symbol size.
- lldb::addr_t size;
+ lldb::addr_t size = 0;
/// The symbol name.
std::string name;
>From 01965b3e05c269b58a633fbb657277115c76f22e Mon Sep 17 00:00:00 2001
From: lexi-nadia <m...@lexibromfield.com>
Date: Fri, 5 Sep 2025 14:22:42 -0400
Subject: [PATCH 2/4] Apply suggestions from code review
Co-authored-by: Jonas Devlieghere <jo...@devlieghere.com>
---
lldb/tools/lldb-dap/Protocol/DAPTypes.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lldb/tools/lldb-dap/Protocol/DAPTypes.h
b/lldb/tools/lldb-dap/Protocol/DAPTypes.h
index 17a25c092b8dd..07bd85b648c8c 100644
--- a/lldb/tools/lldb-dap/Protocol/DAPTypes.h
+++ b/lldb/tools/lldb-dap/Protocol/DAPTypes.h
@@ -66,10 +66,10 @@ struct Symbol {
lldb::SymbolType type = lldb::eSymbolTypeInvalid;
/// The symbol file address.
- lldb::addr_t fileAddress = 0;
+ lldb::addr_t fileAddress = LLDB_INVALID_ADDRESS;
/// The symbol load address.
- std::optional<lldb::addr_t> loadAddress = std::nullopt;
+ std::optional<lldb::addr_t> loadAddress;
/// The symbol size.
lldb::addr_t size = 0;
>From 9a56fd85a0fc13facbaad84395fabc20bba4c957 Mon Sep 17 00:00:00 2001
From: lexinadia <lexina...@google.com>
Date: Fri, 5 Sep 2025 20:10:51 +0000
Subject: [PATCH 3/4] Add a missing #include for LLDB_INVALID_ADDRESS
---
lldb/tools/lldb-dap/Protocol/DAPTypes.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lldb/tools/lldb-dap/Protocol/DAPTypes.h
b/lldb/tools/lldb-dap/Protocol/DAPTypes.h
index 07bd85b648c8c..23ba93946bdee 100644
--- a/lldb/tools/lldb-dap/Protocol/DAPTypes.h
+++ b/lldb/tools/lldb-dap/Protocol/DAPTypes.h
@@ -16,6 +16,7 @@
#ifndef LLDB_TOOLS_LLDB_DAP_PROTOCOL_DAP_TYPES_H
#define LLDB_TOOLS_LLDB_DAP_PROTOCOL_DAP_TYPES_H
+#include "lldb/lldb-defines.h"
#include "lldb/lldb-types.h"
#include "llvm/Support/JSON.h"
#include <optional>
>From 7bc50edc0f02505983d720fddaf981a596adf78e Mon Sep 17 00:00:00 2001
From: lexinadia <lexina...@google.com>
Date: Fri, 5 Sep 2025 21:05:04 +0000
Subject: [PATCH 4/4] Remove filegroup rules for .pyi files removed in
22c2e15408553b2c172d407a8ee417adc2a93757
---
.../mlir/python/BUILD.bazel | 36 -------------------
1 file changed, 36 deletions(-)
diff --git a/utils/bazel/llvm-project-overlay/mlir/python/BUILD.bazel
b/utils/bazel/llvm-project-overlay/mlir/python/BUILD.bazel
index d5385cd3a9650..8114e128d615c 100644
--- a/utils/bazel/llvm-project-overlay/mlir/python/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/python/BUILD.bazel
@@ -32,13 +32,6 @@ filegroup(
],
)
-filegroup(
- name = "ExecutionEnginePyIFiles",
- srcs = [
- "mlir/_mlir_libs/_mlirExecutionEngine.pyi",
- ],
-)
-
filegroup(
name = "IRPyFiles",
srcs = [
@@ -53,14 +46,6 @@ filegroup(
]),
)
-filegroup(
- name = "IRPyIFiles",
- srcs = [
- "mlir/_mlir_libs/_mlir/__init__.pyi",
- "mlir/_mlir_libs/_mlir/ir.pyi",
- ],
-)
-
filegroup(
name = "MlirLibsPyFiles",
srcs = [
@@ -75,13 +60,6 @@ filegroup(
],
)
-filegroup(
- name = "PassManagerPyIFiles",
- srcs = [
- "mlir/_mlir_libs/_mlir/passmanager.pyi",
- ],
-)
-
filegroup(
name = "RewritePyFiles",
srcs = [
@@ -659,13 +637,6 @@ gentbl_filegroup(
],
)
-filegroup(
- name = "PDLPyIFiles",
- srcs = [
- "mlir/_mlir_libs/_mlir/dialects/pdl.pyi",
- ],
-)
-
filegroup(
name = "PDLPyFiles",
srcs = [
@@ -756,13 +727,6 @@ filegroup(
# Quant dialect.
##---------------------------------------------------------------------------##
-filegroup(
- name = "QuantPyIFiles",
- srcs = [
- "mlir/_mlir_libs/_mlir/dialects/quant.pyi",
- ],
-)
-
filegroup(
name = "QuantPyFiles",
srcs = [
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
