DavidSpickett wrote: > With all those neat sequential values across the GPR registers, it's clear > that the file was created artificially.
Yeah, so I was expecting to find some inline asm for that. > The values in some of these registers would differ with each regeneration of > the core file, requiring an update to the test with the actual values, so I'd > prefer to keep the existing test as is. Not if the asm is: ``` mov to fpu <repeats> mov to gpr <repeats> cause a fault ``` Sure the control register values might change but we can get consistent GPRs. I'm not saying we'd regenerate the file on every build, it's just about having the source code to be able to regenerate it if we want/need to. But as I said, I am OK taking this as is. https://github.com/llvm/llvm-project/pull/155956 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
