[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

[David Spickett via lldb-commits]

================
@@ -1593,6 +1620,13 @@ DisassemblerLLVMC::DisassemblerLLVMC(const ArchSpec 
&arch,
     features_str += "+a,+m,";
   }
 
+  llvm::StringRef additional_features = arch.GetDisassemblyFeatures();
+  // Prepend the additional_features if it's not already in the features_str to
+  // avoid duplicates.
+  if (!additional_features.empty()) {
+    UpdateFeatureString(additional_features, features_str);
----------------
DavidSpickett wrote:

UpdateFeatureString will just return early if additional_features is empty, so 
I'd just call it without a check.

https://github.com/llvm/llvm-project/pull/147990
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits