DavidSpickett wrote: > The one significant choice that we haven't agreed on at this point is whether > Architecture::GetArchitectureUnwindPlan should return an empty UnwindPlanSP > to indicate no override, or if it should return the std::shared_ptr<const > UnwindPlan> identical to its input if it indicates that no override has been > done. I want RegisterContetUnwind to be able to detect if its chosen > UnwindPlan has changed, so it's mainly a question of how that is most clearly > indicated, I think.
Yeah it's fine as it is. At first I wondered why you didn't just do `plan = dostuffmaybeto(plan)` but yeah you need some flag that says "yes something was done" because you need to update other stuff if something did change. https://github.com/llvm/llvm-project/pull/153922 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
