JDevlieghere wrote: > Could you use `kNum_Cores` so we don't have to remember to update this when > new ones are added? > > Also the `eCore_wasm32` one has an empty body, so does that mean it does not > get checked?
Good catch, that's an unintentional off-by-one. Using `kNum_Cores` addresses both. > And you say 2 cores were in the wrong order but only one is moved in the > diff. Maybe the other is a downstream thing? Haha, I guess it depends on how you (or the diff algorithm) looks at it. `thumbv7s` and `thumbv7k` showed up before `thumbv7f` which is why I said 2, which of course can be be fixed by moving just `thumbv7f` which is equivalent to moving the other two down. https://github.com/llvm/llvm-project/pull/159452 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
