================ @@ -519,8 +591,9 @@ int main(int argc, char *argv[]) { Socket::SocketProtocol protocol; std::string name; std::tie(protocol, name) = *maybeProtoclAndName; - if (auto Err = serveConnection(protocol, name, log.get(), default_repl_mode, - pre_init_commands)) { + if (auto Err = ---------------- royitaqi wrote:
IIUC the coding convention says that auto can be used when it's obvious what the actual type is from the context. IMHO the type here *is* obvious (`llvm::Error`). With that said, I can spell it out in my next update. https://github.com/llvm/llvm-project/pull/156803 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits