[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

[Nitesh Jain via Phabricator via lldb-commits]

nitesh.jain created this revision.

The MatchesModuleSpec() should return false if module_ref is not found.


https://reviews.llvm.org/D30454

Files:
  source/Core/Module.cpp


Index: source/Core/Module.cpp
===================================================================
--- source/Core/Module.cpp
+++ source/Core/Module.cpp
@@ -1615,10 +1615,10 @@
 
   const ConstString &object_name = module_ref.GetObjectName();
   if (object_name) {
-    if (object_name != GetObjectName())
-      return false;
+    if (object_name == GetObjectName())
+      return true;
   }
-  return true;
+  return false;
 }
 
 bool Module::FindSourceFile(const FileSpec &orig_spec,



Index: source/Core/Module.cpp
===================================================================
--- source/Core/Module.cpp
+++ source/Core/Module.cpp
@@ -1615,10 +1615,10 @@
 
   const ConstString &object_name = module_ref.GetObjectName();
   if (object_name) {
-    if (object_name != GetObjectName())
-      return false;
+    if (object_name == GetObjectName())
+      return true;
   }
-  return true;
+  return false;
 }
 
 bool Module::FindSourceFile(const FileSpec &orig_spec,

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits