DavidSpickett wrote: I'm not clear on the specific purpose here: > Ensure that the nested native CMake build uses the same Python interpreter as > the outer build. > > Unify python shebangs so that they use python3 everywhere, instead of a mix > of python and python3.
Is the first implemented by doing the second? Or are you doing 2 things here? (with so many files I might have missed something) We might be ok with a mass replace of python -> python3 generally, but if you know which specific files fix your use case, I'd prefer to see those in their own PR. So we have a better attribution of problems fixed (or created, as it may be) by each change. Or you can reframe this as "llvm requires python of at least 3, plenty of scripts use python3 already, let's make it consistent". Which is a good pitch that doesn't need the context of your use case. If there is a mass conversion of python shebangs earlier in the git history, you can cite that as precedent. We probably did for some subset of scripts back when we moved to requiring >= 3. Sometimes we will accept changes like this as is, sometimes they need to be broken up. Depends on the sub-projects' attitude to the changes. It can also take a lot of time to get every single part approved. FWIW if you broke out the LLDB changes I'd accept them as is. https://github.com/llvm/llvm-project/pull/163566 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
