royitaqi wrote: > When you merge this, please include a little bit of motivation for > introducing a new external dependency.
I have just updated the "Motivation" section of the patch description to include an explanation. Feel free to LMK if you want me to change anything there. > I skimmed the package and it seems well-established with limited transitive > dependencies, but generally speaking we should have a pretty high bar for > adding new dependencies. If we want less dependency, I can update https://github.com/llvm/llvm-project/pull/159481 so that it only uses the `fs` package (which IIUC should be included by default`, so that it adds zero dependencies). However, that solution checks the modification time of the lldb-dap binary, and is less reliable per @walter-erquinigo 's [comment](https://github.com/llvm/llvm-project/pull/159481#discussion_r2357321672) (I'm still yet to learn why that is the case). https://github.com/llvm/llvm-project/pull/159797 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
