================
@@ -1971,6 +1971,45 @@ size_t Process::ReadMemory(addr_t addr, void *buf,
size_t size, Status &error) {
}
}
+llvm::SmallVector<llvm::MutableArrayRef<uint8_t>>
+Process::ReadMemoryRanges(llvm::ArrayRef<Range<lldb::addr_t, size_t>> ranges,
+ llvm::MutableArrayRef<uint8_t> buffer) {
+ auto total_ranges_len = llvm::sum_of(
+ llvm::map_range(ranges, [](auto range) { return range.size; }));
+ // If the buffer is not large enough, this is a programmer error.
+ // In production builds, gracefully fail by returning empty chunks.
+ assert(buffer.size() >= total_ranges_len);
+ if (buffer.size() < total_ranges_len)
+ return llvm::SmallVector<llvm::MutableArrayRef<uint8_t>>(ranges.size());
----------------
DavidSpickett wrote:
Add an explicit zero value here, it took me ages to parse what this meant
(which is a "C++ be like" sort of issue, but still, make it clearer).
Also you say "chunks" but these are not chunks, we don't return chunks as such
we return a description of a chunk. I suggest "returning a length of 0 for all
ranges".
https://github.com/llvm/llvm-project/pull/163651
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
