Author: Charles Zablit Date: 2025-10-21T10:53:49-07:00 New Revision: d4713ecb6dbe2d6b1f586508b47ad9391da51d66
URL: https://github.com/llvm/llvm-project/commit/d4713ecb6dbe2d6b1f586508b47ad9391da51d66 DIFF: https://github.com/llvm/llvm-project/commit/d4713ecb6dbe2d6b1f586508b47ad9391da51d66.diff LOG: [lldb][windows] add a warning if CMake's version is inferior to 3.30 (#164346) https://github.com/llvm/llvm-project/pull/140443 makes use of the CMake variable `Python3_EXECUTABLE_DEBUG`, which was introduced in CMake version 3.30. On systems with an inferior version of cmake, the lit tests will try to run with an empty `config.python_executable`. This PR adds a warning and falls back to using `Python3_EXECUTABLE` if the CMake version is less than `3.30`. Added: Modified: lldb/test/API/CMakeLists.txt Removed: ################################################################################ diff --git a/lldb/test/API/CMakeLists.txt b/lldb/test/API/CMakeLists.txt index b1ace6296f46a..e3bffbc73c394 100644 --- a/lldb/test/API/CMakeLists.txt +++ b/lldb/test/API/CMakeLists.txt @@ -140,7 +140,12 @@ if(CMAKE_HOST_APPLE) endif() if(WIN32 AND CMAKE_BUILD_TYPE STREQUAL Debug) - set(LLDB_PYTHON_API_TEST_EXECUTABLE "${Python3_EXECUTABLE_DEBUG}") + if(${CMAKE_VERSION} VERSION_LESS "3.30") + message(WARNING "CMake version is inferior to 3.30. Some lldb tests will fail.") + set(LLDB_PYTHON_API_TEST_EXECUTABLE "${Python3_EXECUTABLE}") + else() + set(LLDB_PYTHON_API_TEST_EXECUTABLE "${Python3_EXECUTABLE_DEBUG}") + endif() else() set(LLDB_PYTHON_API_TEST_EXECUTABLE "${Python3_EXECUTABLE}") endif() _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
