https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/164494
>From 13cdc22b45790ff7a780575df3e17debb2af70e0 Mon Sep 17 00:00:00 2001 From: Charles Zablit <[email protected]> Date: Tue, 21 Oct 2025 13:51:59 -0700 Subject: [PATCH 1/3] [lldb] add a warning if `dirname` is not in the PATH --- lldb/test/API/CMakeLists.txt | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lldb/test/API/CMakeLists.txt b/lldb/test/API/CMakeLists.txt index b1ace6296f46a..df2648d3c3518 100644 --- a/lldb/test/API/CMakeLists.txt +++ b/lldb/test/API/CMakeLists.txt @@ -74,6 +74,15 @@ else() endif() endif() +find_program(LLDB_DIRNAME_PATH dirname) +if(LLDB_DIRNAME_PATH) + message(STATUS "Found dirname: ${LLDB_DIRNAME_PATH}") +else() + message(STATUS "Did not find 'dirname'.") + message(WARNING + "Many LLDB API tests require the 'dirname' tool. Please provide it in Path.") +endif() + if (TARGET clang) set(LLDB_DEFAULT_TEST_COMPILER "${LLVM_TOOLS_BINARY_DIR}/clang${CMAKE_EXECUTABLE_SUFFIX}") else() >From 0e5bcf5460136fdbf9288b79ab94881a9b3e0200 Mon Sep 17 00:00:00 2001 From: Charles Zablit <[email protected]> Date: Tue, 21 Oct 2025 15:44:07 -0700 Subject: [PATCH 2/3] Update lldb/test/API/CMakeLists.txt Co-authored-by: nerix <[email protected]> --- lldb/test/API/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lldb/test/API/CMakeLists.txt b/lldb/test/API/CMakeLists.txt index df2648d3c3518..2401af53f5f07 100644 --- a/lldb/test/API/CMakeLists.txt +++ b/lldb/test/API/CMakeLists.txt @@ -78,7 +78,7 @@ find_program(LLDB_DIRNAME_PATH dirname) if(LLDB_DIRNAME_PATH) message(STATUS "Found dirname: ${LLDB_DIRNAME_PATH}") else() - message(STATUS "Did not find 'dirname'.") + message(STATUS "Could NOT find 'dirname'") message(WARNING "Many LLDB API tests require the 'dirname' tool. Please provide it in Path.") endif() >From 6a7c6e431003ffd8f423c39cad911010eda770d0 Mon Sep 17 00:00:00 2001 From: Charles Zablit <[email protected]> Date: Tue, 21 Oct 2025 15:46:27 -0700 Subject: [PATCH 3/3] fixup! [lldb] add a warning if `dirname` is not in the PATH --- lldb/test/API/CMakeLists.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lldb/test/API/CMakeLists.txt b/lldb/test/API/CMakeLists.txt index 2401af53f5f07..233b4c061afe1 100644 --- a/lldb/test/API/CMakeLists.txt +++ b/lldb/test/API/CMakeLists.txt @@ -80,7 +80,8 @@ if(LLDB_DIRNAME_PATH) else() message(STATUS "Could NOT find 'dirname'") message(WARNING - "Many LLDB API tests require the 'dirname' tool. Please provide it in Path.") + "Many LLDB API tests require the GNU coreutils tools. Please make " + "sure they are installed and in PATH.") endif() if (TARGET clang) _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
