mstorsjo wrote:

> I'm debating if, when `SearchPathW` fails to find `python.dll`, we should 
> exit or let lldb crash.
> 
> However, I don't want to prevent lldb from starting if we think `python.dll` 
> is not available, even though it is.

I agree, I think this is the better call. As mentioned above, the current 
guesstimate of the python DLL name would be wrong on mingw, so I'd rather have 
a spurious error message than exiting altogether.

(Also, I wonder if there's some way one can learn the actual python library 
name through the CMake FindPython scripts, rather than having to guess it; 
guessing it seems brittle. E.g. if we manage to switch over to the Python 
stable API, it can be just `python3.dll` instead of `python312.dll`.)

https://github.com/llvm/llvm-project/pull/164893
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to