https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/165604
>From 0180d1275a49aad11c214c3c154561d663aceeeb Mon Sep 17 00:00:00 2001 From: Nerixyz <[email protected]> Date: Wed, 29 Oct 2025 18:41:41 +0100 Subject: [PATCH 1/3] [LLDB] Skip TestMultipleSlides.py on Windows --- .../API/functionalities/multiple-slides/TestMultipleSlides.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py b/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py index 3d6b27fe68a1b..48db92b611cfa 100644 --- a/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py +++ b/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py @@ -12,6 +12,9 @@ class MultipleSlidesTestCase(TestBase): NO_DEBUG_INFO_TESTCASE = True + # DWARF doesn't include public symbols on Windows, so LLDB falls back to the PDB. + # Symbols don't have a size in the native PDB plugin. + @skipIfWindows def test_mulitple_slides(self): """Test that a binary can be slid multiple times correctly.""" self.build() >From 8055f76f8bf095c3510724ec2780fe1f28864382 Mon Sep 17 00:00:00 2001 From: Nerixyz <[email protected]> Date: Wed, 29 Oct 2025 19:22:03 +0100 Subject: [PATCH 2/3] fix: explanation This isn't compiled with DWARF, but linked with -gdwarf, so LLD generates a PDB. --- .../functionalities/multiple-slides/TestMultipleSlides.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py b/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py index 48db92b611cfa..bf219061d5b13 100644 --- a/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py +++ b/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py @@ -12,8 +12,9 @@ class MultipleSlidesTestCase(TestBase): NO_DEBUG_INFO_TESTCASE = True - # DWARF doesn't include public symbols on Windows, so LLDB falls back to the PDB. - # Symbols don't have a size in the native PDB plugin. + # The intermediate object main.o is compiled without debug info, but + # a.out is linked with `-gdwarf` on Windows. This creates a PDB. + # However, in the native PDB plugin, the symbols don't have a size. @skipIfWindows def test_mulitple_slides(self): """Test that a binary can be slid multiple times correctly.""" >From 15f3ea527c3070ff912747f5cb2be47de0c74b93 Mon Sep 17 00:00:00 2001 From: Nerixyz <[email protected]> Date: Wed, 29 Oct 2025 19:38:31 +0100 Subject: [PATCH 3/3] fix: xfail on Windows --- .../API/functionalities/multiple-slides/TestMultipleSlides.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py b/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py index bf219061d5b13..7fd2ff4229004 100644 --- a/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py +++ b/lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py @@ -15,7 +15,7 @@ class MultipleSlidesTestCase(TestBase): # The intermediate object main.o is compiled without debug info, but # a.out is linked with `-gdwarf` on Windows. This creates a PDB. # However, in the native PDB plugin, the symbols don't have a size. - @skipIfWindows + @expectedFailureWindows def test_mulitple_slides(self): """Test that a binary can be slid multiple times correctly.""" self.build() _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
