DavidSpickett wrote: Ok well in a perhaps counter-intuitive way, I'd be ok with some duplication as long as it's basically identical copies. This makes it easier to divide the "copy for convenience" and the "copy and modify for good reasons".
So I think it comes down to what benefits you get from having separate code. Do you have a branch I could look at and see the subsequent changes so I can get an idea of where you need to diverge? It does not have to be review quality, I just need a rough idea of where you're going with this. Also if we're going down the duplication path, I think I'd want to see `ppc64le` and `ppc64be` naming, instead of just `ppc`. I know `ppc` implies `be` but not to anyone who hasn't worked with it before. Then again maybe seeing your changes will change my mind on that. https://github.com/llvm/llvm-project/pull/165367 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
