================
@@ -97,6 +97,9 @@ add_lldb_library(lldbTarget
     lldbUtility
     lldbValueObject
     lldbPluginProcessUtility
+
+  CLANG_LIBS
+    clangCodeGen
----------------
delcypher wrote:

> AFAIU the core of LLDB is supposed to be as generic as possible. Plugins are 
> supposed to provide the abstractions over programming language/runtime 
> specifics. There's some discussion here: 
> https://lldb.llvm.org/resources/contributing.html#lldb-plugins-and-their-dependencies

The VerboseTrapFrameRecognizer isn't part of a plugin though, is it? It's part 
of `lldbTarget`. My other planned use of the new API will be from a 
instrumentation runtime plugin but even then reading the doc it seems to 
primarily be concerned with

* Preventing the core of LLDB depending on a specfific LLDB plugin.
* Preventing LLDB plugins from depending on other LLDB plugins in some 
situations.

Neither of those apply to this PR because `clangCodeGen` is not an LLDB plugin.

https://github.com/llvm/llvm-project/pull/165996
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to