charles-zablit wrote:

> If you feel confident enough in your testing, sure.
> 
> This PR is fine as is though. Worst case it's too cautious and it can be 
> changed later. I suspect the majority of people will be using Windows 
> Terminal by now and if they're not, their first instinct would probably be to 
> see if it solves the issue.

On Windows 11, I have tried:
- Windows Terminal
- Console Host (cmd.exe "old version" and powershell)
- Git Bash

The arrow character of the error message was displayed correctly each time.

Another concern might be the code page because according to 
https://stackoverflow.com/a/15828853, the default codepage (437) does not 
support all Unicode characters. It does support the one we use however.

I will update the doc of the method.

https://github.com/llvm/llvm-project/pull/168603
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to