Author: Charles Zablit
Date: 2025-11-19T17:30:31+01:00
New Revision: c9e22d3751299fe31eeefbfb646bef7a78bcde8a

URL: 
https://github.com/llvm/llvm-project/commit/c9e22d3751299fe31eeefbfb646bef7a78bcde8a
DIFF: 
https://github.com/llvm/llvm-project/commit/c9e22d3751299fe31eeefbfb646bef7a78bcde8a.diff

LOG: [lldb][windows] add color to the Python.dll not found error (#168718)

Make the `Python.dll not found` error message stand out more by using
the `llvm::WithColor::error()` method.

---

### Example

#### Before

<img width="782" height="431" alt="Screenshot 2025-11-19 at 15 50 22"
src="https://github.com/user-attachments/assets/93960c50-cbf2-41f7-aba3-2f2a8af916cc";
/>

#### After

<img width="780" height="430" alt="Screenshot 2025-11-19 at 15 54 28"
src="https://github.com/user-attachments/assets/f7f4954b-0ce3-4a4b-b9af-5af876032573";
/>

rdar://165047059

Added: 
    

Modified: 
    lldb/tools/driver/Driver.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/tools/driver/Driver.cpp b/lldb/tools/driver/Driver.cpp
index bebf1a70d50e9..0b77e0a4929a7 100644
--- a/lldb/tools/driver/Driver.cpp
+++ b/lldb/tools/driver/Driver.cpp
@@ -508,12 +508,12 @@ void SetupPythonRuntimeLibrary() {
   if (AddPythonDLLToSearchPath() && IsPythonDLLInPath())
     return;
 #endif
-  llvm::errs() << "error: unable to find '"
-               << LLDB_PYTHON_RUNTIME_LIBRARY_FILENAME << "'.\n";
+  WithColor::error() << "unable to find '"
+                     << LLDB_PYTHON_RUNTIME_LIBRARY_FILENAME << "'.\n";
   return;
 #elif defined(LLDB_PYTHON_DLL_RELATIVE_PATH)
   if (!AddPythonDLLToSearchPath())
-    llvm::errs() << "error: unable to find the Python runtime library.\n";
+    WithColor::error() << "unable to find the Python runtime library.\n";
 #endif
 }
 #endif


        
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to