igorkudrin wrote:

> I know this seems redundant, but do we have coverage for 64-bit signed too?
> 
> Now would be a good time to add that. To show that reading 64-bit signed into 
> int64_t gives -1, and reading 32-bit signed into int64_t also gives -1, 
> _because_ of the correctly applied sign extension.
> 
> Unlikely we'd ever break the 64-bit ones but it's cheap to check it here and 
> it's a hint toward what the tests expect to see for 32-bit.

I've added some basic tests for reading 64-bit values.

> Your example is on Arm 32-bit but I think this applies to any target as long 
> as the requested signed int is 32-bit. Did I understand correctly?

I've only checked on Arm32, but other 32-bit platforms are probably affected 
too.

https://github.com/llvm/llvm-project/pull/169150
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to