================
@@ -150,29 +152,38 @@ bool 
UnwindAssemblyInstEmulation::GetNonCallSiteUnwindPlanFromAssembly(
   EmulateInstruction::InstructionCondition last_condition =
       EmulateInstruction::UnconditionalCondition;
 
-  for (const InstructionSP &inst : inst_list.Instructions()) {
-    if (!inst)
-      continue;
-    DumpInstToLog(log, *inst, inst_list);
+  std::deque<std::size_t> to_visit = {0};
+  llvm::SmallSet<std::size_t, 0> enqueued = {0};
----------------
JDevlieghere wrote:

What's the point of initializing them like this? Why not 

```
std::deque<std::size_t> to_visit;
llvm::SmallSet<std::size_t, 0> enqueued;
```

This seems needlessly confusing. Now I'm forced to double check that this is 
initializing both to zero elements and not adding a zero to the list (i.e. `= 
{{0}}`). 

https://github.com/llvm/llvm-project/pull/169630
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to