JDevlieghere wrote: > Some things I'm not sure on: > > 1. We can report this as a warning in the debugger using > `Debugger::ReportWarning`. It would happen only once per connection, but it > could become annoying if the warning isn't relevant to you and you can't > avoid it (if you have your specific reasons for having lldb configured this > way).
I would personally prefer this option. If we're worried about it being to spammy, we could also scope it to the debugger or have a static so it's printed only once per LLDB instance. Both are kinda hacky though. Another option is to make it configurable with a setting and including the setting in the warning. The "stepping through optimized code" is another very spammy one that I've been meaning to make configurable. > 2. Not sure if we should be mentioning cmake options in the log message. In a > sense it's too late to check that, but I wanted a way to give some hint. Then > again, you'd have to know to enable the log anyway, so I can remove that hint > and assume a somewhat expert is reading the log and will know what to do. Given that the log is primarily intended for us as LLDB developers, I don't have any concerns with mentioning the CMake option. https://github.com/llvm/llvm-project/pull/170478 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
