dschuff wrote:

I'm definitely not an expert in LLDB, so I don't know if this is the exact way 
to solve this issue, but the behavior should now be correct in the presence of 
import sections.
A couple of questions: I manually edited the YAML test input file (rather than 
recompiling it from clang). I think it's possible to generate function imports 
like that with clang+lld but I'm not sure about global imports.
Secondly: is the value of the `SymID` field significant? If every function has 
a name in the name section (and now, if every import also has a name) then the 
`SymID` will match the functions index in the function index space (and 
previously would have matched the function's index in the code section). The id 
now will never match the code section index if there are imports, and the id 
won't match the function index space if not every function has a name. This 
isn't a problem unless the `SymID` is significant somehow.

https://github.com/llvm/llvm-project/pull/170960
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to