https://github.com/ashgti approved this pull request.
I'm okay with this if we think it will improve stability. However, I think there may still be a few places in tests where we wait for a negative assertion to time out. We may need to make sure we find anymore of those and make them positive assertions so they can end early. For me, if I run the tests with `"-DLLVM_LIT_ARGS='-v --use-unique-output-file-name --time-tests'",` ``` $ ninja check-lldb-api-tools-lldb-dap Slowest Tests: -------------------------------------------------------------------------- 102.61s: lldb-api :: tools/lldb-dap/variables/TestDAP_variables.py 77.41s: lldb-api :: tools/lldb-dap/evaluate/TestDAP_evaluate.py 46.74s: lldb-api :: tools/lldb-dap/launch/TestDAP_launch.py 32.29s: lldb-api :: tools/lldb-dap/module/TestDAP_module.py 32.08s: lldb-api :: tools/lldb-dap/completions/TestDAP_completions.py 28.63s: lldb-api :: tools/lldb-dap/disconnect/TestDAP_disconnect.py 27.49s: lldb-api :: tools/lldb-dap/breakpoint-events/TestDAP_breakpointEvents.py 26.55s: lldb-api :: tools/lldb-dap/server/TestDAP_server.py 26.47s: lldb-api :: tools/lldb-dap/restart/TestDAP_restart.py 24.46s: lldb-api :: tools/lldb-dap/threads/TestDAP_threads.py 20.19s: lldb-api :: tools/lldb-dap/exception/objc/TestDAP_exception_objc.py 19.72s: lldb-api :: tools/lldb-dap/breakpoint/TestDAP_setBreakpoints.py 15.53s: lldb-api :: tools/lldb-dap/console/TestDAP_console.py 15.08s: lldb-api :: tools/lldb-dap/breakpoint/TestDAP_logpoints.py 13.81s: lldb-api :: tools/lldb-dap/databreakpoint/TestDAP_setDataBreakpoints.py 13.81s: lldb-api :: tools/lldb-dap/optimized/TestDAP_optimized.py 13.68s: lldb-api :: tools/lldb-dap/module-event/TestDAP_module_event.py 11.66s: lldb-api :: tools/lldb-dap/memory/TestDAP_memory.py 10.55s: lldb-api :: tools/lldb-dap/terminated-event/TestDAP_terminatedEvent.py 10.48s: lldb-api :: tools/lldb-dap/attach-commands/TestDAP_attachCommands.py ``` I see a few tests that are pretty slow. The slowest ones are where I have been meaning to check for negative assertions on a timeout. https://github.com/llvm/llvm-project/pull/170890 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
