DrSergei wrote:

> As far as I remember `runInTerminal` is not supported on Windows (see my 
> [comment](https://github.com/llvm/llvm-project/issues/161998#issuecomment-3402851311)).
>  Maybe we can change default mode only for non-Windows systems, also don't 
> forget to update documentation in README.md.

One additional comment. To avoid refactoring of c++ code and existed tests that 
rely on default mode, you can add some logic in ts 
[code](https://github.com/llvm/llvm-project/blob/main/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts#L107)
 to set new default value.

https://github.com/llvm/llvm-project/pull/171429
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to