================
@@ -0,0 +1,21 @@
+include "../../../../include/lldb/Core/PropertiesBase.td"
+
+let Definition = "platformwasm" in {
+  def RuntimePath
+      : Property<"runtime-path", "FileSpec">,
+        Global,
+        DefaultStringValue<"">,
+        Desc<"Path to the WebAssembly runtime binary. If the path does not "
+             "contain a directory separator, the filename is looked up in the "
+             "PATH environment variable. If empty, the filename is derived "
+             "from the architecture setting.">;
+  def RuntimeArgs : Property<"runtime-args", "Args">,
+                    Global,
+                    DefaultStringValue<"">,
+                    Desc<"Extra arguments to pass to the WebAssembly 
runtime.">;
+  def PortArg : Property<"port-arg", "String">,
+                Global,
+                DefaultStringValue<"">,
+                Desc<"Argument to the WebAssembly runtime to specify the "
+                     "GDB remote port.">;
----------------
DavidSpickett wrote:

This needs an example. The "Args" above is so to speak "full" like 
"-number-of-things 99 -animal giraffe" which is what most people would assume. 
Whereas the port argument is intended to be only the first part and lldb puts 
the port number in itself.

Which is a good idea to make it flexible, but saying that lldb will append a 
port number and showing an example would explain that better.

So that lldb doesn't attempt to run stuff like `simulator --port 
127.0.0.1:1234:1234`.

Also when that does happen, could you check how the error is shown to the user? 
If they see that command somewhere in the error then great, they can eventually 
figure it out. Failing that, something in a log channel would allow us to help 
them at least.

https://github.com/llvm/llvm-project/pull/171507
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to