jasonmolenda wrote:
> 1. It would be nice if we could consistently use `extractor_sp` for a > `DataExtractorSP` and `data_sp` for a `DataBufferSP`. There's a few cases > where you changed the type but not the member, presumably to limit the number > of lines changed. I think it would be worth the churn to avoid > confusion/surprises down the line. Agreed, I had the same thought while I was finishing this patch up, but was reluctant to expand all the changes to address it. I added a commit to implement this naming convention. > 2. I'm not a huge fan of checking the `ByteSize`. I would prefer an `operator > bool` opr a `HasData()` that checks that instead. Added a DataExtractor::HasData(), switched callers checking for GetByteSize()==0 to use it. https://github.com/llvm/llvm-project/pull/171574 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
