https://github.com/DrSergei approved this pull request.

Is this patch inspired by some performance issues? It looks like that using 
`llvm::StringRef` in `VariableDescription` might be less safe. Maybe we can add 
getters for fields which directly obtained from SBValue. It is just some 
thoughts, feel free to ignore it. Overall, LGTM

https://github.com/llvm/llvm-project/pull/172661
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to