================
@@ -336,3 +338,31 @@ UnwindPlanSP ArchitectureArm::GetArchitectureUnwindPlan(
   }
   return new_plan;
 }
+
+bool ArchitectureArm::IsValidBreakpointInstruction(
+    llvm::ArrayRef<uint8_t> reference, llvm::ArrayRef<uint8_t> observed) const 
{
+  auto is_bkpt = false;
+  if (observed.size() < reference.size())
----------------
DavidSpickett wrote:

This check is the same as the generic implementation, which is ok, but please 
do it the same way around. Unless you're making a point by writing it the other 
way, in which case add a comment saying so.

https://github.com/llvm/llvm-project/pull/174348
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to