xiaobai marked an inline comment as done.
xiaobai added a comment.

I'll resubmit after removing the extra code in the test and get somebody to 
commit for me.



================
Comment at: 
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:373
+
+  result = std::async(std::launch::async, [&] {
+    return client.GetMemoryRegionInfo(addr, region_info);
----------------
labath wrote:
> This seems out of place. Should we delete it?
Whoops! I was going to extend this test further but I decided not to in the end 
and forgot to remove this. Thanks for pointing it out.


https://reviews.llvm.org/D31485



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to