charles-zablit wrote:

> The LLDB changes look good to me. I don't know if it's better to land the 
> LLVM changes separately.

The llvm changes are not justified on their own, as 
`llvm::Expected<CVType>LazyRandomTypeCollection::getTypeOrError(TypeIndex 
Index)` would not be used in the patch. I think this can be merged as is!

LGTM once the merge conflict is fixed ✅ 

https://github.com/llvm/llvm-project/pull/166455
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to