https://github.com/DavidSpickett commented:

Thanks for updating the PR description, very clear now what this changes. Code 
is fine just an optional style comment on that.

Please look into the test cases that exist for this. I know some of them 
require a FreeBSD core parsing library to be installed, so watch out for that. 
If you have trouble getting them to work, I can look at least the corefile 
based ones.

It's likely they're not being run in many (if any) places.

At a glance, the core based tests check that expected threads exist but not 
which one is selected.

https://github.com/llvm/llvm-project/pull/178069
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to