cmtice wrote: Thank you for tackling this!
I have several concerns with the way this PR implements the simple/full DIL idea (BTW, I do like that you added "legacy" to the set of options). My biggest concern is that this does not give users any control over the option at all, unless they are LLVM programmers and can spin their own copy of LLDB and program the change they want. Also, I am dismayed at the number of places that have to be updated if we change the parameters for GetValueForVariablePath/GetValueForVariableExpressionPath. (In addition, I'm not sure that it's OK to change the parameters to functions in the SB API). I would MUCH rather make this a setting that users can control. Then we don't have to touch all the places GetValueForVariablePath (or GetValueForVariableExpressionPath) is called, we don't have to worry about changing the SB API, and (as I said) users can easily change the setting if they want different behavior than whatever default we set. https://github.com/llvm/llvm-project/pull/178747 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
